search

zilliztech / milvus-helm

Apache License 2.0
56 stars 42 forks source link

feat: add ingressClass #109

Closed cin-logan closed 3 months ago

cin-logan commented 3 months ago

What this PR does / why we need it:

Since to EKS version 1.22, deprecated nginx kubernetes.io/ingress.class and we need to upgrade to using ingressClassName then i have create PR to do this

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

sre-ci-robot commented 3 months ago

Welcome @cin-logan! It looks like this is your first PR to zilliztech/milvus-helm 🎉

haorenfsa commented 3 months ago

Hi @cin-logan, it would be better to add an default empty string value in charts/milvus/values.yaml, so that in other people can easily search for this field if they need it. It can also make the to auto generated documents better, like in https://artifacthub.io/packages/helm/milvus/milvus?modal=values.

haorenfsa commented 3 months ago

/approve

cin-logan commented 3 months ago

could you help me to review it again ? thanks @haorenfsa

haorenfsa commented 3 months ago

@cin-logan looks good, please bump the chart version to 4.2.1. And we're ready to merge it.

cin-logan commented 3 months ago

Sorry for the inconvenience, I have force-pushed again 😢. Could you check it, @haorenfsa

sre-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cin-logan, haorenfsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/zilliztech/milvus-helm/blob/master/OWNERS)~~ [haorenfsa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
haorenfsa commented 3 months ago

/lgtm