Closed cin-logan closed 3 months ago
Welcome @cin-logan! It looks like this is your first PR to zilliztech/milvus-helm 🎉
Hi @cin-logan, it would be better to add an default empty string value in charts/milvus/values.yaml
, so that in other people can easily search for this field if they need it. It can also make the to auto generated documents better, like in https://artifacthub.io/packages/helm/milvus/milvus?modal=values.
/approve
could you help me to review it again ? thanks @haorenfsa
@cin-logan looks good, please bump the chart version to 4.2.1. And we're ready to merge it.
Sorry for the inconvenience, I have force-pushed again 😢. Could you check it, @haorenfsa
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cin-logan, haorenfsa
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
What this PR does / why we need it:
Since to EKS version 1.22, deprecated nginx kubernetes.io/ingress.class and we need to upgrade to using ingressClassName then i have create PR to do this
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname]
)