search

zilverline / react-tap-event-plugin

Instant TapEvents for React
http://facebook.github.io/react/
MIT License
1.07k stars 110 forks source link

Stop listening on onTouchCancel. #3

Closed killfill closed 9 years ago

killfill commented 9 years ago

Hi!

Im using this event for a little app, and noticed that on the default android browser (at least the ones of <= 4.4.4) generates falses onTouchCancel events when scrolling.

When you touchStart and move the finger, onTouchCancel is getting triggered (with the finger still pressed). This plugin treat it as a isEndish() so its emitting the onTouchTap event, making the app not very useful.

Probably not everyone loves the default chrome browser, but its the default, and is what been used when you phongap/cordova-ize you app.

Thanks!!

s0meone commented 9 years ago

Thank you for your pull request, I don't always have an Android devise laying around. So I can't test this at this moment. I'm keeping this open until I confirmed the issue and your fix.

s0meone commented 9 years ago

This will probably fix #8 as well.

darkyen commented 9 years ago

can we now publish an updated version on npm ?

s0meone commented 9 years ago

Sorry, I did make a release but forgot to push the package.json with the new version number. The current release on npm (0.1.4) contains this PR.