zimfw / steeef

A customizable version of steeef's prompt theme.
MIT License
4 stars 3 forks source link

Github Password Authentication Removed #4

Open cptalpdeniz opened 2 years ago

cptalpdeniz commented 2 years ago

Describe the bug
As GitHub removed Password authentication, cannot zimfw install steeef theme.

Steps to reproduce
The fist 4 steps restart the shell with a clean installation of Zim in a temporary directory. Use exec zsh when restarting the terminal or restarting the shell is needed.

  1. cd ${$(mktemp -d):A}
  2. ZDOTDIR=${PWD} HOME=${PWD} ZIM_HOME=${PWD}/.zim exec zsh
  3. curl -fsSL https://raw.githubusercontent.com/zimfw/install/master/install.zsh | zsh
  4. exec zsh
  5. Unable to install steeef using zimfw install

Current behavior
When you try to install the steeef theme, it asks for github username and password. However because Github removed support for password authentication, the installation fails.

Expected behavior
Update the theme to use Github personal access token instead.

Screenshots

Screen Shot 2021-10-21 at 10 44 27 PM

zimfw info

zimfw version: 1.5.0 (built at 2021-08-10 14:52:54 UTC, previous commit is 35cd6f5)
ZIM_HOME:      /Users/.../.zim
Zsh version:   5.8
System info:   Darwin something2s-MacBook-Pro.local 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64 x86_64
ericbn commented 2 years ago

Hi @cptalpdeniz.

For the "Support for password authentication was removed on August 13, 2021. Please use a personal access token instead." error you should definitely check https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ as shown in the error message itself. This means setting up a personal access token to replace the GitHub password authentication.

cptalpdeniz commented 2 years ago

Hello Eric, thanks for the prompt response. I understand this is related to git itself. Should solving the issue with git directly solve the installation error for steeef as well or is this something I need to tackle with steeef only?

ericbn commented 2 years ago

Solving the issue with git will directly solve this error. It's not related to steeef in particular.