search

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.24k stars 612 forks source link

fix(graphql): onComplete callback should send null #1304

Closed budde377 closed 1 year ago

budde377 commented 1 year ago

When adding the onComplete callbacks to graphql_codegen I realized that we couldn't distinguish between a failed onComplete and just an empty one. This fix makes the callback send the actual response.data, unmodified.

Related https://github.com/heftapp/graphql_codegen/issues/257

codecov[bot] commented 1 year ago

Codecov Report

Merging #1304 (e5398ed) into main (32040ee) will not change coverage. The diff coverage is 0.00%.

:exclamation: Current head e5398ed differs from pull request most recent head aceff15. Consider uploading reports for the commit aceff15 to get more accurate results

@@           Coverage Diff           @@
##             main    #1304   +/-   ##
=======================================
  Coverage   63.48%   63.48%           
=======================================
  Files          41       41           
  Lines        1687     1687           
=======================================
  Hits         1071     1071           
  Misses        616      616
Impacted Files Coverage Δ
packages/graphql/lib/src/core/query_options.dart 57.48% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

budde377 commented 1 year ago

Cheers! Can we do a beta release?