search

zino-hofmann / graphql-flutter

A GraphQL client for Flutter, bringing all the features from a modern GraphQL client to one easy to use package.
https://zino-hofmann.github.io/graphql-flutter
MIT License
3.23k stars 613 forks source link

feat: added onConnectionLost function to WebSocket config #1364

Closed vytautas-pranskunas- closed 1 year ago

vytautas-pranskunas- commented 1 year ago

Fixes / Enhancements

onConnectionLost function to WebSocket

Docs

Fixes https://github.com/zino-hofmann/graphql-flutter/issues/1323

codecov[bot] commented 1 year ago

Codecov Report

Merging #1364 (d20407f) into main (6eaa2d2) will increase coverage by 0.16%. The diff coverage is 100.00%.

:exclamation: Current head d20407f differs from pull request most recent head 227ed80. Consider uploading reports for the commit 227ed80 to get more accurate results

@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
+ Coverage   63.67%   63.83%   +0.16%     
==========================================
  Files          41       41              
  Lines        1696     1698       +2     
==========================================
+ Hits         1080     1084       +4     
+ Misses        616      614       -2
Impacted Files Coverage Δ
...lib/src/links/websocket_link/websocket_client.dart 81.22% <100.00%> (+1.12%) :arrow_up:
vytautas-pranskunas- commented 1 year ago

P.s I will fix version

vincenzopalazzo commented 1 year ago

P.s I will fix version

Run also make dep && make, the rules are equal for everyone. as it is for me that I must push code well-formatted, it is also for you

vytautas-pranskunas- commented 1 year ago

But his is general change not ment only for tokens :)

vytautas-pranskunas- commented 1 year ago

ok commits are squashed

vincenzopalazzo commented 1 year ago

Mh why your commit is signed by me? this looks odd in fact the commit in github is unverified, this means that I did not sign it

vytautas-pranskunas- commented 1 year ago

Have no idea.... I just squashed them and that's it. I understand your awareness about git history but Can we skip all these 'git history' things... at the end code is most important :) Meanwhile I have made one more PR branch from yesterday's one (which also may make git history not the coolest but did that because i needed all changes). Would you mind reviewing it and releasing - those really blocks me from releasing our APP.

Thanks :)

On Mon, 24 Jul 2023 at 13:02, Vincenzo Palazzo @.***> wrote:

Mh why your commit is signed by me? this looks odd

— Reply to this email directly, view it on GitHub https://github.com/zino-hofmann/graphql-flutter/pull/1364#issuecomment-1647695046, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA54ZF5A2U3YJBEJW4QW7HLXRZI5XANCNFSM6AAAAAA2UOFCPE . You are receiving this because you authored the thread.Message ID: @.***>

--

Pagarbiai,

Vytautas Pranskunas

vincenzopalazzo commented 1 year ago

Have no idea.... I just squashed them and that's it. I understand your awareness about git history but Can we skip all these 'git history' things... at the end code is most important :)

No, because if there is some bugs I need to fix your mess :)

Would you mind reviewing it and releasing - those really blocks me from releasing our APP.

If the code and the git history is not good enough I will not, sorry!

vytautas-pranskunas- commented 1 year ago

Ok as i see that your goal is not to maintain this project but to mess with git. I am not good at git whatsoever and do not have time for it.. Most likely i will use my own fork to have these features on board because i even do not now ehre to start fighting with git. Those changes are too trivial to talk about them for so long. :)

On Mon, 24 Jul 2023 at 13:41, Vincenzo Palazzo @.***> wrote:

Have no idea.... I just squashed them and that's it. I understand your awareness about git history but Can we skip all these 'git history' things... at the end code is most important :)

No, because if there is some bugs I need to fix your mess :)

Would you mind reviewing it and releasing - those really blocks me from releasing our APP.

If the code and the git history is not good enough I will not, sorry!

— Reply to this email directly, view it on GitHub https://github.com/zino-hofmann/graphql-flutter/pull/1364#issuecomment-1647748504, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA54ZF6Y2EUIBOFLZZH7XHDXRZNPFANCNFSM6AAAAAA2UOFCPE . You are receiving this because you authored the thread.Message ID: @.***>

--

Pagarbiai,

Vytautas Pranskunas

vytautas-pranskunas- commented 1 year ago

p.s. i can do it in only way - if you write me commands that i have to write because fighting with git for me not acceptable at this point in time

On Mon, 24 Jul 2023 at 13:51, Vytautas Pranskūnas @.***> wrote:

Ok as i see that your goal is not to maintain this project but to mess with git. I am not good at git whatsoever and do not have time for it.. Most likely i will use my own fork to have these features on board because i even do not now ehre to start fighting with git. Those changes are too trivial to talk about them for so long. :)

On Mon, 24 Jul 2023 at 13:41, Vincenzo Palazzo @.***> wrote:

Have no idea.... I just squashed them and that's it. I understand your awareness about git history but Can we skip all these 'git history' things... at the end code is most important :)

No, because if there is some bugs I need to fix your mess :)

Would you mind reviewing it and releasing - those really blocks me from releasing our APP.

If the code and the git history is not good enough I will not, sorry!

— Reply to this email directly, view it on GitHub https://github.com/zino-hofmann/graphql-flutter/pull/1364#issuecomment-1647748504, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA54ZF6Y2EUIBOFLZZH7XHDXRZNPFANCNFSM6AAAAAA2UOFCPE . You are receiving this because you authored the thread.Message ID: @.***>

--

Pagarbiai,

Vytautas Pranskunas

--

Pagarbiai,

Vytautas Pranskunas

vytautas-pranskunas- commented 1 year ago

so Vincenzo,

Either please help me to put those features to package that you maintain either you can transfer them manually and do with git history all things that you like :) What would you say?

Cheers Vytautas

On Mon, 24 Jul 2023 at 13:56, Vytautas Pranskūnas @.***> wrote:

p.s. i can do it in only way - if you write me commands that i have to write because fighting with git for me not acceptable at this point in time

On Mon, 24 Jul 2023 at 13:51, Vytautas Pranskūnas @.***> wrote:

Ok as i see that your goal is not to maintain this project but to mess with git. I am not good at git whatsoever and do not have time for it.. Most likely i will use my own fork to have these features on board because i even do not now ehre to start fighting with git. Those changes are too trivial to talk about them for so long. :)

On Mon, 24 Jul 2023 at 13:41, Vincenzo Palazzo @.***> wrote:

Have no idea.... I just squashed them and that's it. I understand your awareness about git history but Can we skip all these 'git history' things... at the end code is most important :)

No, because if there is some bugs I need to fix your mess :)

Would you mind reviewing it and releasing - those really blocks me from releasing our APP.

If the code and the git history is not good enough I will not, sorry!

— Reply to this email directly, view it on GitHub https://github.com/zino-hofmann/graphql-flutter/pull/1364#issuecomment-1647748504, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA54ZF6Y2EUIBOFLZZH7XHDXRZNPFANCNFSM6AAAAAA2UOFCPE . You are receiving this because you authored the thread.Message ID: @.***>

--

Pagarbiai,

Vytautas Pranskunas

--

Pagarbiai,

Vytautas Pranskunas

--

Pagarbiai,

Vytautas Pranskunas

vytautas-pranskunas- commented 1 year ago

Hi again, what I did was I created a new branch and copied both changes there. This is all I could do. I have created PR for you. If this also does not suit you then I give up.

Have a great day.

On Mon, 24 Jul 2023 at 14:22, Vytautas Pranskūnas @.***> wrote:

so Vincenzo,

Either please help me to put those features to package that you maintain either you can transfer them manually and do with git history all things that you like :) What would you say?

Cheers Vytautas

On Mon, 24 Jul 2023 at 13:56, Vytautas Pranskūnas @.***> wrote:

p.s. i can do it in only way - if you write me commands that i have to write because fighting with git for me not acceptable at this point in time

On Mon, 24 Jul 2023 at 13:51, Vytautas Pranskūnas @.***> wrote:

Ok as i see that your goal is not to maintain this project but to mess with git. I am not good at git whatsoever and do not have time for it.. Most likely i will use my own fork to have these features on board because i even do not now ehre to start fighting with git. Those changes are too trivial to talk about them for so long. :)

On Mon, 24 Jul 2023 at 13:41, Vincenzo Palazzo @.***> wrote:

Have no idea.... I just squashed them and that's it. I understand your awareness about git history but Can we skip all these 'git history' things... at the end code is most important :)

No, because if there is some bugs I need to fix your mess :)

Would you mind reviewing it and releasing - those really blocks me from releasing our APP.

If the code and the git history is not good enough I will not, sorry!

— Reply to this email directly, view it on GitHub https://github.com/zino-hofmann/graphql-flutter/pull/1364#issuecomment-1647748504, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA54ZF6Y2EUIBOFLZZH7XHDXRZNPFANCNFSM6AAAAAA2UOFCPE . You are receiving this because you authored the thread.Message ID: @.***>

--

Pagarbiai,

Vytautas Pranskunas

--

Pagarbiai,

Vytautas Pranskunas

--

Pagarbiai,

Vytautas Pranskunas

--

Pagarbiai,

Vytautas Pranskunas