search

zipme / redmine_lightbox

Lightbox for image attachments
MIT License
116 stars 119 forks source link

Chrome pdf viewer fix, configurable image previews [closed] #42

Closed nettsundere closed 8 years ago

nettsundere commented 12 years ago

Added jquery_loader (jquery shouldn't be loaded twice) Fixed directory structure Fixed chrome pdf-viewer compatibility (issue #19 ) (current chrome cannot load the pdf document if its content-disposition header is set to "attachment". It's a bug (They should, at least, ask user to download it). Pdf with "inline" content-disposition is ok. Disabled navigation for the pdf documents (With this patch you can use your pdf-viewer features) Fixed preview image sizing method (now they cannot stretch too long) Added ability to disable previews for the images via plugin settings

Tested with redmine-1.4

Maybe you can use some of this changes

boot2linux commented 11 years ago

who can provide patch to support firefox builtin PDF viewer ?

boot2linux commented 11 years ago

Dear nettsundere, would u like to make repository "https://github.com/Undev/redmine_lightbox" support redmine 2.1.x ? B.R.

nettsundere commented 11 years ago

Yes. I'm working on it now

nettsundere commented 11 years ago

If you have https://github.com/dagwieers/unoconv installed, this version will create a pdf previews for doc, docx, rtf files and show them instead of original files (which can still be downloaded via link)

boot2linux commented 11 years ago

any plan to merge "Chrome pdf viewer fix" ?

nettsundere commented 8 years ago

Hi everyone.

The title says "nettsundere wants to merge 46 commits into zipme:master from Restream:master", but unfortunately i do not want to. I've created this request many years ago and things have changed since then. I am not happy about changes you have made (especially about fancy words in code comments) and i do believe that is more than enough to close the request. I should have closed this one couple of years ago. Feel free to open your own. Cheers.

nettsundere commented 8 years ago

Update: fixed autocorrect 🐇