search

zivl / sentry-testkit

A Sentry plugin to allow Sentry report interception and further inspection of the data being sent
https://zivl.github.io/sentry-testkit/
MIT License
112 stars 26 forks source link

Support Sentry v8 #200

Open Slessi opened 6 months ago

Slessi commented 6 months ago

Is your feature request related to a problem? Please describe. I am trying to update my project to use sentry v8, but was blocked by apollo-link-sentry. I tried to update that package in https://github.com/DiederikvandenB/apollo-link-sentry/pull/467 but the tests are failing, and it may be due to this package.

Tests pass individually, but fail if ran together, so I am not sure the testkit.reset() is working in v8 anymore.

Describe the solution you'd like sentry-testkit to work with sentry v8

Describe alternatives you've considered Quitting JS development and starting a farm

Additional context

Slessi commented 6 months ago

Seems like there was actually just a problem on my part in https://github.com/DiederikvandenB/apollo-link-sentry/pull/467#discussion_r1607118365, so I'm not blocked by this. Worth keeping the issue open though as probably still desirable to update.

zivl commented 6 months ago

hey @Slessi yeah you are right... we need to add support for the new major version of Sentry@8 packages. I actually believe we are also compatible with Sentry@8 but first let's read the breaking changes carefully and add some tests.

I think the go to from here is to be able to install different sentry versions in the github action CI workflow and by that to verify we are always on the good side of things :)

github-actions[bot] commented 4 months ago

Stale issue message

arnaudcombes commented 3 months ago

hey @zivl, are pull requests appreciated? We are currently blocked in the update of the Sentry library

zivl commented 3 months ago

@arnaudcombes sure! I'll be happy for your help 🙏 🙏 🙏