search

zjedi / hugo-scroll

Clean, responsive, single-page Hugo website theme.
https://themes.gohugo.io/hugo-scroll/
MIT License
271 stars 193 forks source link

invalid type <icon> should be <i> for fork awesome #195

Closed schellingerhout closed 3 months ago

schellingerhout commented 3 months ago

https://github.com/zjedi/hugo-scroll/blob/807c028d71512e31291683b204d7e35c2a704bbe/layouts/index.html#L67

Relatively harmless in real world, but causes a W3 validator tool error.

Simply replace icon with i and issue is resolved

this is in line with the shortcode

https://github.com/zjedi/hugo-scroll/blob/807c028d71512e31291683b204d7e35c2a704bbe/layouts/shortcodes/icon.html#L1

zjedi commented 3 months ago

Sounds truly harmless, would you care to open a pull request for this?

schellingerhout commented 3 months ago

Sure! I'll do that tonight