search

zk1931 / jzab

ZooKeeper Atomic Broadcast in Java
http://zk1931.github.io/jzab/master/
Apache License 2.0
54 stars 23 forks source link

right protobuf-java version? #170

Closed rgs1 closed 9 years ago

rgs1 commented 10 years ago

I think this needs protobuf-java > 2.4.1. I had to make this change to get it to build:

diff --git a/pom.xml b/pom.xml
index 483c876..f89ff55 100644
--- a/pom.xml
+++ b/pom.xml
@@ -275,7 +275,7 @@
     <dependency>
       <groupId>com.google.protobuf</groupId>
       <artifactId>protobuf-java</artifactId>
-      <version>2.4.1</version>
+      <version>2.5.0</version>
     </dependency>
     <dependency>
       <groupId>io.netty</groupId>
rgs1 commented 10 years ago

https://github.com/zk1931/jzab/pull/171

EasonLiao commented 10 years ago

Thanks for trying out, I think as long as the version of protobuf-java and protoc are consistent, its OK.