search

zk1931 / jzab

ZooKeeper Atomic Broadcast in Java
http://zk1931.github.io/jzab/master/
Apache License 2.0
54 stars 23 forks source link

Heartbeat message should go through SyncProposalProcessor #182

Open EasonLiao opened 10 years ago

EasonLiao commented 10 years ago

I'm not sure, if you look at the slides of the talk, you can see the latency of the proposal can be more than 1 second while taking snapshot. This is for multiple fsync and for sure the latency will be higher if the user just do one gigantic fsync. I'm afraid this will cause the timeout if the timeout value is too small.

ghost commented 10 years ago

i think that's the intended behavior. heartbeating is less meaningful if it can't detect that disk is busy. the user needs to configure the timeout according to the expected state size. let's discuss this tomorrow.