zkmopro / mopro

Making client-side proving on mobile simple.
https://zkmopro.org
Apache License 2.0
131 stars 35 forks source link

chore: remove ark-circom #211

Closed vivianjeng closed 4 months ago

vivianjeng commented 4 months ago
build time with ark-circom without ark-circom
debug 1m 07s 42.80s
release 4m 00s 3m 48s
chancehudson commented 4 months ago

I think instead of moving ark-circom into mopro-ffi, we should try to move logic out to ark-circom. The zkey.rs and zkey_header.rs could both go out to ark-circom. We can also try to push changes from our ark-circom to arkworks-rs/circom-compat. Specifically the zkey loading and native witness gen.

vivianjeng commented 4 months ago

I see. That makes sense. I will do it in another PR