search

zkmopro / mopro

Making client-side proving on mobile simple.
https://zkmopro.org
Apache License 2.0
131 stars 35 forks source link

fix ark-circom version #224

Open vivianjeng opened 4 months ago

vivianjeng commented 4 months ago

Problem

ark-circom v0.1.0 has been published https://crates.io/crates/ark-circom so the cargo publish will find the crate in crates.io first

Details

We published mopro-ffi v0.1.0 but the cargo uses the ark-circom crate above so we have to patch the ark-circom with

[patch.crates-io]
ark-circom = { git = "https://github.com/zkmopro/circom-compat.git", version = "0.1.0", branch = "wasm-delete" }

we will either

  1. publish our ark-circom in zkmopro/circom-compat so that we can find the crate and specific version
  2. find a way to use crate in github without showing the error messages e.g. 
    
Updating crates.io index
Packaging mopro-ffi v0.1.0 (/Users/zhengyawen/Documents/GitHub/mopro/mopro-ffi)
Updating crates.io index
error: failed to prepare local package for uploading

Caused by: no matching package named rust-witness found location searched: registry crates-io required by package mopro-ffi v0.1.0 (/Users/zhengyawen/Documents/GitHub/mopro/mopro-ffi)



in the next release

## Acceptance criteria
Apps can install `mopro-ffi` without patching the `ark-circom`

## Next steps (optional)
Remove the patch instructions in doc