zkopru-network / zkopru

Ethereum L2 scaling solution for private transactions using zk-SNARK and optimistic rollup.
https://zkopru.network
GNU General Public License v3.0
217 stars 28 forks source link

[chore] fix tx size calculation for memoV2 #385

Closed tkmct closed 2 years ago

tkmct commented 2 years ago

This PR update tx size calculation for memoV2 but does not include calculation with prepayInfo. close #377

sifnoc commented 2 years ago

That's nice! I think It would be better to add more test code for size matching in the v2 memo type.

tkmct commented 2 years ago

Okay, I'll add more test code then.

tkmct commented 2 years ago

@sifnoc hi, I added test cases. can you take a look?

sifnoc commented 2 years ago

@sifnoc hi, I added test cases. can you take a look?

Looks good to me! Thank you :+1: