zlainsama / OfflineSkins

This mod allows you to show off your skins even if the server is in offline mode.
https://minecraft.curseforge.com/projects/offlineskins
MIT License
45 stars 18 forks source link

Just some informations about my fork ( Custom server support ) #15

Open Aang23 opened 7 years ago

Aang23 commented 7 years ago

Someone has made a very good implementation of a custom skin server, but never finished it, when you told me to search one, I had to correct it, and finally done it, I will keep updating my fork for all versions you support. Just an information if someone need it.

zlainsama commented 6 years ago

I added support for custom server in 1.12.2-v2. It also has better caching behavior to reduce network traffic.

Aang23 commented 6 years ago

Thanks ! I was planning to upgrade it to 1.12.2... So, there is no backports of your own implementation in 1.11.2 / 1.10.2 / etc ? Else I may do it, should be useful.

zlainsama commented 6 years ago

If you want to do it, i am fine with that. This current implementation requires java 8, prior versions of minecraft don't necessarily run on java 8, they could be on java 7 or 6.

Aang23 commented 6 years ago

I could implements a config option for compatibility with prior Java like 7 / 6. This should fix the issue.

C0rn3j commented 6 years ago

@zlainsama >I added support for custom server in 1.12.2-v2.

I came here wanting to ask for this feature and it has already been done, awesome job.

Though this feature is nowhere to be found in the documentation, would you please do the following?

zlainsama commented 6 years ago

I added one line in project description on curse forge to indicate this feature exist.

C0rn3j commented 6 years ago

@zlainsama Could you add to the documentation in the cfg or elsewhere what exactly does the mod expect?

I assume it's in the same format as the official server, but a person looking at it won't figure that out without a bunch of googling.

http://skins.minecraft.net/MinecraftSkins/[yourusername].png http://skins.minecraft.net/MinecraftCloaks/[yourusername].png

zlainsama commented 6 years ago

I remember I added description in the config file when I was implementing the feature.

They are: (replace example.com with your server ip or domain name) http://example.com/skins/uuid.png http://example.com/skins/username.png http://example.com/capes/uuid.png http://example.com/capes/username.png

Https is also supported.

C0rn3j commented 6 years ago

Actually that doesn't work, the mod requests the names without the extension. If I remove the extension it works, the mod is awesome ^^

37.191.175.185 - - [24/Oct/2017:17:03:46 +0000] "GET /skins/C0rn3j HTTP/1.1" 200 2542 "-" "Java/1.8.0_144"
37.191.175.185 - - [24/Oct/2017:17:03:47 +0000] "GET /capes/C0rn3j HTTP/1.1" 404 178 "-" "Java/1.8.0_144"
zlainsama commented 6 years ago

Oh, my bad. Yes, without '.png'

HeyItzCarlos commented 1 year ago

how would i go to do this? do i remove the extension on my custom server?

C0rn3j commented 1 year ago

Either that or make a rule in your web server.

HeyItzCarlos commented 1 year ago

Thanks, after reading a lot of times and experimenting with the things said in this "issue" i finally figured it out on how to make it work on 1.12.2

again, many thanks lol