search

zlatko-minev / pyEPR

Powerful, automated analysis and design of quantum microwave chips & devices [Energy-Participation Ratio and more]
https://pyepr-docs.readthedocs.io
Other
168 stars 232 forks source link

Add dissipative elements as arguments to `ProjectInfo` #103

Closed nikosavola closed 2 years ago

nikosavola commented 2 years ago

This PR implements adding dissipative elements as arguments to ProjectInfo as suggested in #102. Is this an okay design choice?

Closes #102

zlatko-minev commented 2 years ago

This is good. However, since this is a fairly significant change to the operation for the user, could you add a note somewhere in the documentation about this, so that we can point people to it or how to use it

nikosavola commented 2 years ago

This is good. However, since this is a fairly significant change to the operation for the user, could you add a note somewhere in the documentation about this, so that we can point people to it or how to use it

I now added this to the example code in README and 3.1. Start-up quick example in the docs and a bit more to the tutorial notebook.

zlatko-minev commented 2 years ago

Awesome, thank you. Appreciate it very much will be very helpful