search

zlatko-minev / pyEPR

Powerful, automated analysis and design of quantum microwave chips & devices [Energy-Participation Ratio and more]
https://pyepr-docs.readthedocs.io
Other
168 stars 232 forks source link

Fixed Tutorial 1 #27

Closed DanielCohenHillel closed 4 years ago

DanielCohenHillel commented 4 years ago

The tutorial was created for an older version of the code and did not run In[17] with the current version.

The function DistributedAnalysis.get_freqs_bare_pd() added an option to either return a pandas dataframe or a pandas series with the frame option. The tutorial was created at a time when the function only returned a pandas series. There are other (probably better) ways to fix this issue but I chose the one that changes the least.

zlatko-minev commented 4 years ago

Thank you, Daniel. Good catch. Please do push upstream these kinds of issues as you run across them.

I will start compiling a list of labs that use pyEPR on the main readme, can I add your lab to it?

DanielCohenHillel commented 4 years ago

Hi Zlatko, I'm glad I could help :) I've actually noticed some problems in the second tutorial with the use of ansys.CalcObject. It used to be imported with pyEPR.core but it was restructured so I think now it need to be imported directly from pyEPR.ansys . There are several other errors and I'm checking them now.

Not sure if that's what you meant but I'm from the Quantum Circuits Lab lead by Serge Rosenblum at the Weizmann Institute. I don't think he would have a problem with that but I'll ask him.