search

zlatko-minev / pyEPR

Powerful, automated analysis and design of quantum microwave chips & devices [Energy-Participation Ratio and more]
https://pyepr-docs.readthedocs.io
Other
168 stars 232 forks source link

Fixed issue #21 incompatible with pandas 0.25.1 #30

Closed DanielCohenHillel closed 4 years ago

DanielCohenHillel commented 4 years ago

pandas.compat is private in the newer versions of pandas so you cant use pandas.compat.StringIo. I used the io library instead which provides a similar functionality.

Please check that this actually works for you! I tried it with pandas 1.0.3 and it works, but I cannot guarantee that it won't break anything else.

The way the convergence data is stored and manipulated is a bit unclear (the variable text stores all the data and to get the convergence data you need to use text2 = text.split('==...')[3]). Maybe we can replace it with something like a dictionary to make it easier to work with?

Next time I'll push directly to the repo instead of PR :)

DanielCohenHillel commented 4 years ago

Oh it's an HFSS thing. I did think it's weird that you're using a string to hold the data.

zlatko-minev commented 4 years ago

Yes, it's only temporary. Looks about right I will pull this in for now, and will test more soon.