zlatko-minev / pyEPR

Powerful, automated analysis and design of quantum microwave chips & devices [Energy-Participation Ratio and more]
https://pyepr-docs.readthedocs.io
Other
163 stars 227 forks source link

mode number error in QuantumAnalysis #87

Closed hatlabcz closed 2 years ago

hatlabcz commented 2 years ago

https://github.com/zlatko-minev/pyEPR/blob/59983735bf1c1dc7b02b2db0aa11545f2f840e52/pyEPR/core_quantum_analysis.py#L268

When variations argument inQuantumAnalysis does not contain '0', self.n_modes = len(self.modes['0']) will raise KeyError.

github-actions[bot] commented 2 years ago

👏👏👏 You are awesome! Thank you for making your first issue to pyEPR ' first issue

zlatko-minev commented 2 years ago

Thanks a lot Hat Lab, any chance you could make up a pull request to fix this issue?

hatlabcz commented 2 years ago

Hi Zlatko, I just submitted a pull request that should fix this problem. Thx

zlatko-minev commented 2 years ago

Awesome, thanks a lot, saw Michael last Friday