search

zlsa / atc

https://openscope.co/
342 stars 107 forks source link

V3 Debugging (5 very minor bugs) #711

Closed Fechulo closed 7 years ago

Fechulo commented 7 years ago

As requested by @erikquinn, I set out to find as many bugs as I could and I found 5 very minor ones. Since I didn't want to spend much time typing up a report with screenshots and other things, I decided to just record a quick video (4:45)

TL;DW: -Range rings are too bright -A/C type is lower case on the flight strips -Readback given after A/C are cleared for T/O is buggy -Callsigns of GA A/C are broken (e.g. CESSNA376HO instead of N376HO) -A/C struggle to join the localizer (This is probably the only bug in the list that should be fixed before release)

n8rzz commented 7 years ago

Every bug is a bug and I take each one seriously. By all means, be ruthless! My goal with this refactor has been for the normal user to not notice any difference (aside from some performance improvements).

I've gone ahead and added each issue to my fork (for easier tracking) for each of the items you've called out and also included some screen grabs from your video. That video turned out to be very helpful, so thank you very much for that.

As you find more, if you find more (hopefully), please call them out.

Fechulo commented 7 years ago

@n8rzz I certainly will! 😄

n8rzz commented 7 years ago

@Fechulo you will see we've merged in bugfixes for all but one of the issues you reported and am pushing out a new build now. When you have a chance, could you take a look and verify that the ones that are marked as fixed are in fact fixed?

Strike that, there are still two issues open. n8rzz#64 will be merged here soon.

n8rzz commented 7 years ago

@Fechulo n8rzz#64 has now been merged and deployed.

erikquinn commented 7 years ago

Reference the following issues brought up above:

-Range rings are too bright

Resoved by #702.

-A/C type is lower case on the flight strips

Resoved by #702.

-Readback given after A/C are cleared for T/O is buggy

Resoved by #702.

-Callsigns of GA A/C are broken (e.g. CESSNA376HO instead of N376HO)

Resoved by #702.

-A/C struggle to join the localizer (This is probably the only bug in the list that should be fixed before release)

Created a fresh issue in this repo (#717) as a catch-all with the appropriate references, rendering this a duplicate. Can now be closed.