search

zlsa / atc

https://openscope.co/
342 stars 107 forks source link

OMDB Multiple Aircraft with Same Call Sign Error #744

Closed scott-j-smith closed 7 years ago

scott-j-smith commented 7 years ago

Hi,

Playing OMDB for quite a while, and just got an error stating I have multiple aircraft with the same call sign, which is UAE540.

I checked the console and I realized one is an arrival and one is a departure.

image

n8rzz commented 7 years ago

I can see how that might be a thing. I believe when callsigns are generated, they are generated without any knowledge of previously generated callsigns.

I've added an issue to my fork so we can get this fixed within the next release or two. Thanks for the report!

erikquinn commented 7 years ago

@n8rzz I know previously all callsigns were ensured to be unique upon generation (really, it was only the flight number, so for example it wouldn't create AAL527 and UAL527, because "527" is already in the formerly-named prop.game.callsigns).

scott-j-smith commented 7 years ago

I'm getting the same issue on SBGL also, both are arrivals this time. So it's not limited to the airport.

image

n8rzz commented 7 years ago

@scott-j-smith I believe we have this fixed in v3.2.0, but I was not able to reproduce this in my testing.

How long were you playing before you saw this issue? Are you able to reproduce this consistently? Or does it 'just happen sometimes'?

scott-j-smith commented 7 years ago

@n8rzz I was only playing for about 15 min. today before it showed up on SBGL, but almost an hour on OMDB. It seems to be random because I played SBGL yesterday for almost an hour and it never happened, though I haven't tried to reproduce it specifically.

n8rzz commented 7 years ago

hmm. Ok, well that helps a little bit. I'll run both of those on timewarp 50 and see if I can hit it. With the changes I've made in v3.2.0, you shouldn't ever see duplicate flight numbers. But I'll give both of these airports a try and see if I can replicate.

If you see this anywhere else, please let me know.

scott-j-smith commented 7 years ago

Will do. Thanks.

On Mon, Nov 28, 2016 at 4:20 PM, Nate Geslin notifications@github.com wrote:

hmm. Ok, well that helps a little bit. I'll run both of those on timewarp 50 and see if I can hit it. With the changes I've made in v3.2.0, you shouldn't ever see duplicate flight numbers. But I'll give both of these airports a try and see if I can replicate.

If you see this anywhere else, please let me know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zlsa/atc/issues/744#issuecomment-263397778, or mute the thread https://github.com/notifications/unsubscribe-auth/AVXawNm2T4278nMyszoRYsNtAUJ_iSlMks5rC0WhgaJpZM4K7FiE .

erikquinn commented 7 years ago

The fact that it's again the same airline and flight number, and not just the number makes it infinitely more likely the instance is somehow being duplicated. @n8rzz I doubt the generateFlightNumber stuff you worked on recently isn't working. I'm sure it's fine. Is there any chance something is being _cloned?

n8rzz commented 7 years ago

I just stepped through OMDB for about a half hour on timewarp 75, with the code in v3.2.0. There were several times where a duplicate flight number was generated, however, every time it was identified as a duplicate and re-generated before leaving the generateFlightNumber method.

I am confident my refactor will solve this problem.

One thing we may want to look at is how the random numbers are being generated.

XC-Zhang commented 7 years ago

Duplicate flight number occurred in EGLL after about 10 minutes, both are departure. bug

henk23 commented 7 years ago

Same issue here, played for just a few minutes. multiple

erikquinn commented 7 years ago

Resolved by #755. Closing.