Closed mischeaux closed 7 years ago
Good news, that command seems to work without error in the upcoming v3.2.0 release.
In fact, I know exactly the line of code you are talking about and it is not lying to you; fixOk
was in fact undefined. The end of v3.2 development is scheduled for 12/19. It's just a few weeks away!
Hello,
Could this be the source to the following error:
Uncaught TypeError: Invalid parameter. Expected
valueToClampto be a number(…)
in core.js line 122
I get the fixOK error on issuing a "fix waypoint" command to an aircraft in LOWW, but in other airports seems to work just fine
thanks!
That is probably a different issue. The error your seeing here is likely a result of undefined being passed as the second argument to that function.
Which airport and command did you use to get this error?
I agree that rr is broken, at multiple airports. Trying to string together a couple of waypoints with 'rr waypoint1..waypoint2' and I can't even press enter. (Amazing game, by the way --- great to hear a fix is coming.)
After looking more carefully this is what happens on LOWW airport:
GET https://zlsa.github.io/atc/assets/airlines/msr.json 404 (Not Found)
@georgeenciu thank you for the additional information! That will really help in tracking this down.
Off the top of my head, this looks like it may be an undefined speed or altitude setting in with a Waypoint
in the fms. By issuing the dvs
command those waypoints get updated and then, probably, speed and altitude get set correctly. The errors that are showing up in the console are a side effect of the actual problem. Again, I'm guessing here.
I would expect fixOk
to fail because it is actually undefined in that method. Not desired, but presently expected (and fixed in v3.2.0).
I'll take a look at this tonight on v3.2.0 and see what I can track down. Once I do, I will probably add an issue on my fork for this. At which point I will link back here for visibility.
also, the msr.json
404 is concerning. That is likely a missing file.
CALLSIGN STAR mabod.mabod4k.loww
does work without error on v3.2.0.
CALLSIGN rr balad..ww172
does work without error on v3.2.0
CALLSIGN fix balad
does work without error on v3.2.0
THY6421 rr ww172..balad
does not work on v3.2.0
THY6421 fix ww172
does not work on v3.2.0
@erikquinn I am fairly certain that the non-working commands are related to #700.
Thanks @n8rzz for your info! Then it's not me ;)
@mischeaux good news, the new CommandParser
successfully parses the two commands above that were failing. This will be released as part of v3.3.0 a little later this month.
adding https://github.com/n8rzz/atc/pull/179 and #755 for tracking purposes
Resolved by #755. Closing.
Hi, I'm new to zlsa/atc an having problems with the rr command. Let's say I want to reroute an arrival in eddm for rwy 26r I type in THY3034 rr RATGI..DM438..GUDEG After pressing Enter nothing happens. Am I doing something wrong? I saw this possibility at ATC Tuturial Part 3-Video...
btw: After pressing Enter Java throws following exception: AircraftFlightManagementSystem.js:491Uncaught TypeError: fixOK is not a function(…)
But the most important: You've done such a great job!!! It's real fun to play this one ;)
Thanks Michael