search

zmap / zannotate

Utility for annotating Internet datasets with contextual metadata (e.g., origin AS, MaxMind GeoIP2, reverse DNS, and WHOIS)
Apache License 2.0
95 stars 17 forks source link

log -> logrus #6

Closed ajholland closed 7 years ago

ajholland commented 7 years ago

Wasn't sure if this was for a reason, if so, please ignore.

ajholland commented 7 years ago

Pushed a commit, when adding an entry to the table, if that single entry fails to be added I found it easier to just error that instead of fataling.

If you don't want that I can remove the commit.

zakird commented 7 years ago

Yeah, I think this should probably be a Fatal. What caused this to happen? I've never seen this before in real life.

ajholland commented 7 years ago

The error was "well-known attribute BGPAttrType(45) must have transitive flag 1", I used a different rib and didn't have an issue. Must've just picked a buggy rib.