zmartzone / lua-resty-openidc

OpenID Connect Relying Party and OAuth 2.0 Resource Server implementation in Lua for NGINX / OpenResty
Apache License 2.0
976 stars 249 forks source link

Revert the deprecation of the redirect_uri_path option #496

Open voronin-ilya opened 1 year ago

voronin-ilya commented 1 year ago
Environment
Expected behaviour

The OAuth provider I am using mandates that the redirect_uri be a relative path (/user/${user}/oauth_callback), and this setting cannot be altered on the provider's end. I anticipated the ability to configure lua-resty-openidc accordingly.

Actual behaviour

I had to modify the code because currently, the redirect_uri (and redirect_uri_path) is invariably transformed into an absolute URL.

https://github.com/voronin-ilya/lua-resty-openidc/commit/381c7ce1896bdcc8972debcab9fa66bf1907af16

Proposal

To ensure compatibility with the JupyterHub OAuth provider, I propose rolling back the deprecation of the redirect_uri_path option.