fix: Fix kscan prop existence test in physical layouts

zmkfirmware / zmk

ZMK Firmware Repository

https://zmk.dev/

MIT License

2.82k stars 2.85k forks source link

fix: Fix kscan prop existence test in physical layouts #2615

Closed caksoylar closed 2 weeks ago

caksoylar commented 2 weeks ago

Currently building with a chosen physical layout which has a kscan, but no chosen "shared" kscan fails. See example build and corresponding failing overlay.

I am guessing this is because DT_INST_PROP_LEN doesn't work for phandle type properties, and we can use DT_INST_NODE_HAS_PROP instead. (I haven't spent too much time looking into this, happy to change if there is a better check.)

caksoylar commented 2 weeks ago

I think this might be a problem with an older ZMK version and doesn't currently reproduce, sorry about the noise.