feat(jmx): add jmx rule to base java image

[lwpk110]

@CodiumAI-Agent /improve

[CodiumAI-Agent]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Add error handling for the curl command to prevent silent build failures ___ **Consider adding error handling for the curl command to ensure that the build process does not proceed if the JMX Prometheus Java agent jar file cannot be downloaded. This can prevent silent failures during the build.** [hbase/Dockerfile [22-24]](https://github.com/zncdatadev/containers/pull/77/files#diff-ce14ed7f1742d00a3067c6faae8083437afc542e655ac7e8d941f12e66d16842R22-R24) ```diff curl -sSfL \ https://repo1.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/${JMX_EXPORTER_VERSION}/jmx_prometheus_javaagent-${JMX_EXPORTER_VERSION}.jar \ - -o /kubedoop/jmx/jmx_prometheus_javaagent-${JMX_EXPORTER_VERSION}.jar + -o /kubedoop/jmx/jmx_prometheus_javaagent-${JMX_EXPORTER_VERSION}.jar || { echo "Failed to download JMX Prometheus Java agent jar"; exit 1; } ``` Suggestion importance[1-10]: 9 Why: Adding error handling for the curl command is crucial to prevent the build process from proceeding in case of a download failure, which addresses a potential issue and improves the robustness of the build process.	9
Enhancement	Include the '_sum' metric for Prometheus 'Summary' metrics in Kafka JMX configuration ___ **For the Kafka JMX metrics configuration, it's recommended to include the '_sum' metric for Prometheus 'Summary' metrics to provide a complete set of data for performance analysis.** [kafka/kubedoop/jmx/config-1.0.1/config.yaml [73]](https://github.com/zncdatadev/containers/pull/77/files#diff-d97f39b15c1fe95426aaee4f47652803794fe54262b1458fd819401d358b96d3R73-R73) ```diff -# Note that these are missing the '_sum' metric! - pattern: kafka.(\w+)<>Count + name: kafka_$1_$2_$3_sum + type: COUNTER + labels: + "$4": "$5" + "$6": "$7" ``` Suggestion importance[1-10]: 8 Why: Including the '_sum' metric provides a more complete set of data for performance analysis, enhancing the utility of the metrics for monitoring and analysis purposes.	8
	Standardize metrics names with a common prefix for better identification ___ **To ensure that the metrics names are consistent and follow a common naming convention, consider using a uniform prefix for all metrics names. This will help in easier identification and grouping of metrics related to Hadoop services.** [hadoop/kubedoop/jmx/config-1.0.1/datanode.yaml [17-51]](https://github.com/zncdatadev/containers/pull/77/files#diff-ec01633089121a2f5f5a312293fc01507d9a4d202aded6cf54135e6d8e8c9fc1R17-R51) ```diff -name: hadoop_$1_$3 -name: hadoop_$1_$3 -name: hadoop_$1_$4 -name: hadoop_$1_$3 +name: hadoop_datanode_$1_$3 +name: hadoop_datanode_$1_$3 +name: hadoop_datanode_$1_$4 +name: hadoop_datanode_$1_$3 ``` Suggestion importance[1-10]: 7 Why: The suggestion to use a uniform prefix for metrics names improves consistency and makes it easier to identify and group related metrics, enhancing maintainability and readability.	7
Best practice	Prefix all Spark metrics with 'spark_' for clarity and to avoid naming conflicts ___ **To avoid potential naming conflicts and to enhance clarity, consider prefixing all Spark metrics with 'spark_' to clearly differentiate them from other metrics.** [spark-k8s/kubedoop/jmx/config-1.0.1/config.yaml [7-17]](https://github.com/zncdatadev/containers/pull/77/files#diff-895e36b7c48cd89998ac766123113a2c3bd719a676f55a0a40117585a3140f07R7-R17) ```diff -name: spark_master_$1 -name: spark_worker_$1 -name: spark_driver_$2_$3 +name: spark_spark_master_$1 +name: spark_spark_worker_$1 +name: spark_spark_driver_$2_$3 ``` Suggestion importance[1-10]: 6 Why: Prefixing Spark metrics with 'spark_' helps avoid potential naming conflicts and enhances clarity, which is a good practice for maintaining clear and organized metric naming conventions.	6