search

znerol / node-delta

Delta.js - A JavaScript diff and patch engine for DOM trees
http://znerol.github.com/node-delta/
MIT License
46 stars 11 forks source link

xmlRoundtripTest failed #11

Closed milos-cuculovic closed 4 years ago

milos-cuculovic commented 4 years ago

Hello, I have an issue while running the make test:

xmlRoundtripTest ✖ SVG roundtrip (XCC)

Error: Failed to start attribute at Object.TextWriter.startAttributeNS (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/libxmljs/lib/textwriter.js:110:15) at DOMWriter.writeAttribute (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:73:17) at DOMWriter.writeElement (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:55:18) at DOMWriter.writeNode (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:8:18) at DOMWriter.writeElement (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:60:14) at DOMWriter.writeNode (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:8:18) at DOMWriter.writeElement (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:60:14) at DOMWriter.writeNode (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:8:18) at DOMWriter.writeElement (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:60:14) at DOMWriter.writeDocument (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:95:10)

✔ SVG identity (XCC) ✖ SVG roundtrip (Skel-Match)

Error: Failed to start attribute Object.TextWriter.startAttributeNS (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/libxmljs/lib/textwriter.js:110:15) at DOMWriter.writeAttribute (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:73:17) at DOMWriter.writeElement (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:55:18) at DOMWriter.writeNode (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:8:18) at DOMWriter.writeElement (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:60:14) at DOMWriter.writeNode (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:8:18) at DOMWriter.writeElement (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:60:14) at DOMWriter.writeNode (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:8:18) at DOMWriter.writeElement (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:60:14) at DOMWriter.writeDocument (/Users/miloscuculovic/PycharmProjects/XMLDiffAnalyzer/XMLDiffTools/node-delta/node_modules/xmlshim/domwriter.js:95:10)

Am I missing something? Thank you in advance.

znerol commented 4 years ago

Thanks for the report. Could you please specify which node version and OS you are using.

milos-cuculovic commented 4 years ago

Thanks znerol! v12.16.1 on OSx

znerol commented 4 years ago

Oh, interesting. The last travis job shows the same failures on Linux for all node versions :/

milos-cuculovic commented 4 years ago

That's exactly the one I have. Confirming node 10 works well with the 0.0.5 release of node-delta, but would be good to also use the upgraded version and enjoy new & improved features :)

znerol commented 4 years ago

Looks like this was caused by an update to xmlshim dependencies. If I downgrade jsdom over there, then the tests pass

znerol commented 4 years ago

Published 0.0.7, that one should work without test failures and with node 12

milos-cuculovic commented 4 years ago

Thanks a lot, works now.