zoho / SalesIQ-Mobilisten-ReactNative

Your mobile app's ideal live chat partner. Power up your mobile App with the SalesIQ Mobilisten SDK for React-Native.
https://mobilisten.io/
9 stars 11 forks source link

AAPT error on RN 0.63 #5

Closed RageOfJustice closed 3 years ago

RageOfJustice commented 4 years ago

Hello. Faced the error when trying to build on new RN version (current 0.63).

It could be fixed by adding safeExtGet. I have changed:

android {
    compileSdkVersion 23
    buildToolsVersion "23.0.1"

    defaultConfig {
        minSdkVersion 16
        targetSdkVersion 22
        versionCode 1
        versionName "1.0"
    }
}

with this


def safeExtGet(prop, fallback) {
  rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

android {
  compileSdkVersion safeExtGet('compileSdkVersion', 28)
  buildToolsVersion safeExtGet('buildToolsVersion', '28.0.3')

  defaultConfig {
    minSdkVersion safeExtGet('minSdkVersion', 16)
    targetSdkVersion safeExtGet('targetSdkVersion', 28)
    versionCode 1
    versionName "1.0"
  }

}
Angu-G commented 4 years ago

Thanks for the suggestion. We will have this change in our update which can be expected by the second week of October.

Angu-G commented 3 years ago

Hai @RageOfJustice, This is handled in our latest version (v1.4.0). Thank you