zooniverse / condorwatch

1 stars 1 forks source link

Error in Condor IDs on Bio page #95

Open vjbakker opened 6 years ago

vjbakker commented 6 years ago

After you press "all animals marked" on CondorWatch, you get a list of tags and buttons for bios for each bird marked. The tag list is now all repeats of the last bird marked. Below is a screenshot example in which tag 52 was the last bird marked.

Fortunately, the underlying bios are correct. However, this glitch is clearly a concern to the volunteers and they have reported it. I'm guessing the issue is associated with the changes made to the site 3 months ago (use then instead of pipe). I am not sure why that change were implemented but the timing is right.

errorexample

srallen commented 6 years ago

There was a major security vulnerability in older versions of jQuery, so we had to upgrade to jQuery version 3. Version 3 deprecated the pipe method in favor of then because it more closely matches the newer Javascript Promises specification.

Anyway, my understanding is that the underlying behavior of pipe and then should be the same, but there may have been a difference in how it works that I missed when I updated this.

vjbakker commented 6 years ago
Hmm, is
    there any way to fix this? 

srallen wrote on 4/30/2018 3:02 PM:

  There was a major security vulnerability in older versions of
    jQuery, so we had to upgrade to jQuery version 3. Version 3
    deprecated the pipe method in favor of then
    because it more closely matches the newer Javascript Promises
    specification.
  Anyway, my understanding is that the underlying behavior of pipe
    and then should be the same, but there may have
    been a difference in how it works that I missed when I updated
    this.
  —
    You are receiving this because you authored the thread.
    Reply to this email directly, view it on GitHub, or mute the thread.

  {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/zooniverse/condorwatch","title":"zooniverse/condorwatch","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/zooniverse/condorwatch"}},"updates":{"snippets":[{"icon":"PERSON","message":"@srallen in #95: There was a major security vulnerability in older versions of jQuery, so we had to upgrade to jQuery version 3. Version 3 deprecated the `pipe` method in favor of `then` because it more closely matches the newer Javascript Promises specification.\r\n\r\nAnyway, my understanding is that the underlying behavior of `pipe` and `then` should be the same, but there may have been a difference in how it works that I missed when I updated this. "}],"action":{"name":"View Issue","url":"https://github.com/zooniverse/condorwatch/issues/95#issuecomment-385527883"}}}
srallen commented 6 years ago

I would guess there's a fix, but to be sure we would first try to replicate the bug to understand it. Since this is only affecting the summary bio screen and not classification submission, then we'll try to get to it when we can, but other bugs and features may get higher priority.