search

zoonproject / zoon

The zoon R package
Other
61 stars 13 forks source link

module checks don't check the function has the correct name #372

Open goldingn opened 7 years ago

goldingn commented 7 years ago

E.g. I just managed to merge this, but despite changing the docs I forgot to change the function name from PrintMap PrintOccurrenceMap d'oh!

https://github.com/zoonproject/modules/pull/118/commits/a218faab6dd8b0cda74fab265d00790855726676

I then get this error loading it:

Carolina_Wren_Workflow <- workflow(occurrence = CarolinaWrenPO,
                                   covariate = CarolinaWrenRasters,
                                   process = Background(100),
                                   model = LogisticRegression,
                                   output = PrintOccurrenceMap)
Caught errors:
Error in do.call(outputName[[1]]$func, c(list(.model = x[[1]], .ras = x[[2]]$ras), : could not find function "PrintOccurrenceMap"

I'll fix the modules repo now, but we should amend the tests to catch this