zpl-c / enet

⚡️ ENet reliable UDP networking library
https://blog.zpl.pw
MIT License
688 stars 59 forks source link

ENet Timeouts Linear Change Depricated Settings #50

Open astoll opened 7 months ago

astoll commented 7 months ago

I was looking through the flow to try to understand the timeout values supplied to enet_peer_timeout and I'm not understanding the purpose of timeoutMinimum. I traced a change back to commit f2c0ec3 where enet timeouts were changed from exponential back-off to a more linear approach and I viewed the linked cubik.org discussion and perhaps the change is fine, but I can't see the purpose of timeoutMinimum with that change as roundTripTimeout will never be greater/equal to roundTripTimeoutLimit unless timeoutLimit is 0 or 1 which I wouldn't think would be a valid case?

Perhaps I'm misunderstanding the purpose of this change? Thanks.