search

zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
200 stars 193 forks source link

store: Make isLoading false after getting a event queue #1013

Closed satyam372 closed 1 month ago

satyam372 commented 1 month ago

Fixes: zulip#979

gnprice commented 1 month ago

Is there a particular question you'd like feedback on related to this draft PR?

satyam372 commented 1 month ago

Yeah, I just want feedback on the changes. Before attempting to solve the issue, I followed the steps mentioned by @PIG208 in the description of issue #979:

**I don't have a consistent way to reproduce this, but what I did was basically:

1.Leave the app on and lock the phone. 2.After a while, unlock the phone. 3.Observe if the loading indicator stays visible longer than usual. 4.Try to do something (like starring a message), and the loading indicator should go away promptly.**

I tried this, but it worked fine for me; there was no visible loading indicator (or maybe I did it incorrectly). So, I'm not sure if these changes will solve the issue or not.

This PR doesn't include tests yet. I will include them and push the revision soon.

gnprice commented 1 month ago

Yes, as that description says, we don't know a way to consistently reproduce the issue.

The main work that's needed for making progress on this issue will be to debug it: to figure out how and why it happens, or at least reach some sort of theory for why it might happen. That requires either experimenting to find a reproducer, or carefully studying the code and thinking through possible scenarios.

This PR adds isLoading = false lines in a couple of arbitrary places in the code. Without a theory of why those would affect the issue, that isn't helpful.

Closing this PR because it isn't going in a useful direction.