search

zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
202 stars 195 forks source link

compose: Error banner for deactivated DM recipient has lost its top margin #1089

Open chrisbobbe opened 4 days ago

chrisbobbe commented 4 days ago

In 3adb39557c51604d85741664026c85225fba52fa (fyi @PIG208), we regressed on the layout of the error banner shown when a DM recipient is deactivated:

Before After
image image

The top margin disappeared, and it looks buggy.

I plan to fix this in a PR that's mostly focused on proposing some prep refactors to make a cleaner starting point for #720. (If those refactors seem good, Zixuan can rebase #924 past them.)

PIG208 commented 4 days ago

Thanks to sending this issue! eb9fccd7515b50ec30148eb688b3d6c2b6bb3b31 (from #924) intersects with this by using the same _ErrorBanner class for the error banner here and the one that appears above the compose box.

I noticed that I didn't post a screenshot for this. Added it to #924. Also starting a discussion on the design of this.