search

zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
202 stars 195 forks source link

test: Use color checks that tolerate floating-point errors #949

Closed chrisbobbe closed 2 months ago

chrisbobbe commented 2 months ago

Done to follow a draft migration guide: https://github.com/flutter/website/blob/997c893ccec5fb15dd085a4d23fe8c43870c631b/src/content/release/breaking-changes/wide-gamut-framework.md for the proposed breaking change that raised https://github.com/flutter/flutter/issues/155113

Some other work was needed outside what's described in that draft; see: https://github.com/flutter/flutter/issues/155113#issuecomment-2347374468 https://github.com/flutter/flutter/issues/155113#issuecomment-2356356254

chrisbobbe commented 2 months ago

Yep! Revision pushed, PTAL.

gnprice commented 2 months ago

Thanks! Looks good — merging.