zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
202 stars 195 forks source link

made List and Map items non-nullable #960

Open ArpanMondalGITHUB opened 2 months ago

ArpanMondalGITHUB commented 2 months ago

made the pigeon/notification.dart file List and Map items non-nullable #942

chrisbobbe commented 1 month ago

Please fix the CI failure and write your commit message according to our style, before we can give this a proper review.

ArpanMondalGITHUB commented 4 weeks ago

i messed up the branch and the changes that i made for this pr ... i tried to cherry pick but no use ,so i had to delete the branch . can i make a another branch and make a pr for this issue and close this issue .. sorry its my 1st time with all that git command ...from next i will read 1st the git help docs...

gnprice commented 3 weeks ago

There's nothing to be accomplished by closing this PR and making a new one. Whatever commits you would want to push for the new PR, you can push as an update to this PR instead. See Zulip's Git guide here: https://zulip.readthedocs.io/en/latest/git/using.html#force-push-changes-to-github-after-you-ve-altered-your-history

If you have questions on how to do that, the #git help channel is the best place to ask.