zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
200 stars 193 forks source link

Apply emoji-display nuances to message content, same as reactions #966

Open gnprice opened 2 months ago

gnprice commented 2 months ago

When emoji appear as emoji reactions on messages, there are a couple of nuances to how we decide exactly what to show:

For details of these, see lib/widgets/emoji_reaction.dart.

When emoji appear in message content, however, we don't currently do any of the above.

I believe this discrepancy is only because the rendering of emoji in message content dates to the early prototype, when I was skipping over gnarly details of Zulip that didn't seem relevant to evaluating Flutter, while the rendering of emoji reactions was built (by @chrisbobbe) at a somewhat later stage. So we should add those same nuances to emoji in message content.

Filing this as a post-launch issue, though, because I don't think zulip-mobile handles any of these nuances. Also these are all fairly unusual situations and I don't think we've heard any users mention them — I noticed the discrepancy only through working on the code, for #669.