search

zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
202 stars 195 forks source link

backoff: Make duration bounds customizable #975

Closed gnprice closed 1 month ago

gnprice commented 2 months ago

This will let us have some backoff loops that back off more patiently than others, e.g. because their work is happening in the background and isn't expected to be something the user is already waiting for.

In particular I plan to use this for backing off the fetch of server emoji data, for #669.

chrisbobbe commented 1 month ago

Ah I reviewed this before I noticed it was assigned to @PIG208. LGTM, but I'd be happy to wait for @PIG208's review if that's desired or @PIG208 if you've started yours already. :)

PIG208 commented 1 month ago

Sorry for the delay! Posted a comment. This LGTM overall.

gnprice commented 1 month ago

Thanks for the reviews! Merging, with that tweak.