search

zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
200 stars 193 forks source link

Fetch server emoji data (about Unicode emoji) #976

Closed gnprice closed 1 month ago

gnprice commented 1 month ago

Stacked atop #975.

This completes the data we'll need for use in #669.

gnprice commented 1 month ago

Thanks for the review! Pushed a revision.

chrisbobbe commented 1 month ago

When you say "handle explicitly" in https://github.com/zulip/zulip-flutter/pull/976#discussion_r1792632915, do you mean making InitialSnapshot.serverEmojiDataUrl optional with a TODO? I noticed that isn't done in this revision. 🙂

gnprice commented 1 month ago

Oops, I didn't push my latest revision. :slightly_smiling_face: Pushed now.

chrisbobbe commented 1 month ago

Thanks! LGTM; please merge at will once CI has passed.