zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
202 stars 195 forks source link

Update "bot" icon #978

Closed gnprice closed 1 month ago

gnprice commented 2 months ago

When a message was sent by a bot, we put an icon by the sender's name to indicate it's a bot.

In the web app the icon we use was recently redesigned:

to a friendlier-looking "bot" face with one antenna instead of two antennas. We should update to the new one-antenna icon.

Reported by @alexmv in chat: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Bot.20icon.20asset.20needs.20update/near/1953361

fombalang commented 1 month ago

Hi @gnprice I would like to work on this issue, please.

gnprice commented 1 month ago

Sure, please go ahead.

fombalang commented 1 month ago

Alright!

fombalang commented 1 month ago

Hello I have updated the bot icon.

Screenshot_20241004-085226

Screenshot_20241004-085217

Before I send a PR for this, I would like to verify if a change like this would require that tests be made or updated? Seeing as I only updated the icon SVG file and ran the tools/icons/build-icon-font command without changing any Dart code?

Thank you

gnprice commented 1 month ago

Cool ­— please go ahead and send the PR. This change will be fine without tests.

In general if you have a change that you think may not need tests, I recommend sending the PR without tests but then calling that question out clearly in the PR description. That helps speed things along if reviewers agree that tests aren't needed. It also means reviewers can see the rest of your changes, which can help answer the question of whether tests are needed.

fombalang commented 1 month ago

Okay, Understood