search

zulip / zulip-flutter

Upcoming Zulip mobile apps for Android and iOS, using Flutter
Apache License 2.0
200 stars 193 forks source link

deps: Upgrade video_player_android to 2.7.8 #983

Closed rajveermalviya closed 1 month ago

rajveermalviya commented 1 month ago

Changelog: https://pub.dev/packages/video_player_android/changelog

This update addresses a few bug fixes, including the removal of a flag that treats warnings as errors. Without this fix, Android builds fail in Android Studio 2024.2, which uses Java 21, with the following error:

…
warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
error: warnings found and -Werror specified

With this update the warnings still stay, but are ignored by build system resulting in a successful build.

gnprice commented 1 month ago

Thanks! Looks good; merging.

From the package's changelog, it looks like there's one potentially user-facing bug this fixes:

I couldn't reproduce that in our app on a quick attempt, though, so it might not affect us for some reason. Anyway, added a quick note about it to the commit message.