zulip / zulip-terminal

Official Zulip terminal client.
Apache License 2.0
640 stars 247 forks source link

Highlight matching substrings in message search results #1195

Open mounilKshah opened 2 years ago

mounilKshah commented 2 years ago

While performing a search, the results are based on matching not just the entire text string in the search box but also the possible substrings. This is quite helpful.

However, while displaying the results, the web app highlights the matching substrings. Eg.

Web app results interface

matching_subtrings_webapp

Current Zulip-terminal results interface

matching_subtrings_zulipTerminal

I think implementing this would make the search results easier to go through.

neiljp commented 2 years ago

This is certainly something we can look at, though there is the caveat that we need to make it distinct from other text styles and make it applicable anywhere, which could certainly be challenging since I suspect this would need to modify the urwid markup.

This is a subset of improving search in ZT, since we only support plain text search right now. See #458 and #638. I've labelled those and this issue accordingly.