zulip / zulipbot

GitHub workflow-optimizing bot by @zulip
Other
84 stars 65 forks source link

contributors still limited when claiming issues when repository has a large number of contributors. #230

Open laurynmm opened 1 year ago

laurynmm commented 1 year ago

In general, zulipbot limits new contributors to claiming one issue with the idea that once the contributor has a contribution successfully merged that the limit will be removed.

I think that the code in zulipbot used to check if a contributor has a merged contribution to a repository uses this GitHub API: https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#list-repository-contributors.

And that response is limited to information on only the first 500 author email addresses ordered by number of commits:

To improve performance, only the first 500 author email addresses in the repository link to GitHub users. The rest will appear as anonymous contributors without associated GitHub user information.

Due to the number of contributors being well over 500 for the zulip/zulip repository (:tada:), this means that the limit of one issue won't be removed until the contributor has 3+ commits merged.

So it would be good to either find another way to check if the contributor has a merged commit in the repository for this check or maybe to adjust the zulipbot messages to be clear that the limitation to one issue will remain for their first few commits.

See relevant CZO conversation.


Current zulipbot message sent to contributors when limited to one issue.

Hello new contributor, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!