zunath / SWLOR_NWN

Star Wars: Legends of the Old Republic server code, a persistent world for Neverwinter Nights
40 stars 98 forks source link

Revamp - Bugs #3 #1380

Closed zunath closed 2 years ago

zunath commented 2 years ago

Tracking bugs found in revamp testing. New thread created as the old one was getting cluttered.

Bug ticket 1: https://github.com/zunath/SWLOR_NWN/issues/1130 Bug ticket 2: https://github.com/zunath/SWLOR_NWN/issues/1359

zunath commented 2 years ago

It's possible to double search scavenge points. Click on one from an angle where you can't open it. Then move around and click again from when you can. Opening it will result in two search rolls with two chances to spawn contents - but still only XP based on the second roll.

zunath commented 2 years ago

Saberstaff can't be uncombined if you don't have the saberstaff perk.

zunath commented 2 years ago

The code in the attack roll that determines the character's facing uses their facing -before- the attack not their facing during it. If a character turns to attack, they will be treated as having their old facing for the purpose of backstab calculations. This is abusable.

zunath commented 2 years ago

Appearance editor is throwing this exception - something related to part 18. Could be an off by one error.

Exception type: System.Collections.Generic.KeyNotFoundException Message : The given key '18' was not present in the dictionary. Stacktrace: at System.Collections.Generic.Dictionary2.get_Item(TKey key) at SWLOR.Game.Server.Feature.GuiDefinition.ViewModel.AppearanceEditorViewModel.LoadBodyParts() in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Feature\GuiDefinition\ViewModel\AppearanceEditorViewModel.cs:line 451 at SWLOR.Game.Server.Feature.GuiDefinition.ViewModel.AppearanceEditorViewModel.Initialize(GuiPayloadBase initialPayload) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Feature\GuiDefinition\ViewModel\AppearanceEditorViewModel.cs:line 213 at SWLOR.Game.Server.Service.GuiService.GuiViewModelBase2.Bind(UInt32 player, Int32 windowToken, GuiRectangle initialGeometry, GuiWindowType type, GuiPayloadBase payload, UInt32 tetherObject) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Service\GuiService\GuiViewModelBase.cs:line 199 at SWLOR.Game.Server.Service.Gui.TogglePlayerWindow(UInt32 player, GuiWindowType type, GuiPayloadBase payload, UInt32 tetherObject) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Service\Gui.cs:line 326 at SWLOR.Game.Server.Feature.GuiDefinition.ViewModel.CharacterSheetViewModel.b__91_0() in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Feature\GuiDefinition\ViewModel\CharacterSheetViewModel.cs:line 236 at SWLOR.Game.Server.Service.Gui.HandleNuiEvents() in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Service\Gui.cs:line 230 at SWLOR.Game.Server.Core.Internal.RunScripts(String script) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Core\Internal.cs:line 133

zunath commented 2 years ago

Bug Report Targeting issue in space. System swapped my ship info with an NPC ship's details.

Bug Report can not dock while being targested but there is no one anywhere near me

zunath commented 2 years ago

Bug Report Bug: Player's armor is lost and not re-granted after changing Appearance parts during a persistent pose animation.

~`Steps to Reproduce:~~

  1. Log in to SWLOR Revamp 2022
  2. Purchase an armor set from Sal Vulcano, or any nearby vendor.
  3. Equip the armor set on the character
  4. Enter a persistent pose animation (for example, /pointpistol )
  5. Open the Character Sheet.
  6. Select Appearance > Equipment > Left Forearm > Next Part.
  7. Notice that the character's armor set is removed as expected for Appearance changes, but it is not re-granted to the character.

Notes: This was discovered on a Female Human, but likely applies to all characters due to persistent pose animations being available to all. Ending the persistent pose does not cause the missing armor to appear again.

Platform: Windows PC Build: NWNEE v86.8193.34.1 [b8d939f8] GPU: NVIDIA GeForce RTX 2060

Player: Xisifer Character: QA Gal CD Key: QR7KMGNG

zunath commented 2 years ago

Bug Report Viscaran Flour isn't available from the cooking vendors on CZ=220 and Viscara as a minimum, haven't checked any other planets, but can only assume also missing if they all use the same template. Really hinders one's progress in cooking since there's only a handful of recipes not requiring the flour.

Zun note: Only thing that drops this item are outlaws. I think we should probably put it in the NPC shops.

zunath commented 2 years ago

Bug Report Accepted a Bounty Hunter Guild quest to hand in 6x Mynock Tooth. Handed in 5x. Quest tracked fine, logs fine.

However in the list of tasks, it is still showing as (Available) rather than (ACCEPTED), but if you click into it, it does save the progress as if it's been accepted, so likely just a text error.

Unsure if any other quests are likewise affected, will just report them short hand if I find them.

zunath commented 2 years ago

Bug Report Kinrath just don't do damage to me. They are definitely hitting me though, but just no damage.

Phys. Def - 49 Area Name Viscara - Wildwoods Area Tag viscarawildwoods Area Resref viscarawildwoods Position (101.77087, 99.55576, 101.77087) Date Reported 2022-05-09 05:49:06 Player ID 0e37dce6-c78e-4f32-bfff-1500b88f2fff

zunath commented 2 years ago

Bug Report Viscara - Wildwoods Map does not appear to work. Looted one, used it, but it has not filled in all the dark areas on my map.

Previous maps found all working as intended. (CZ-220, Veles, Viscara - Wildlands)

zunath commented 2 years ago

Bug Report The rename (Unique Self Power) on bags doesn't seem to be working. It is /there/ where is an improvement over legacy half the time, but when you click on it nothing happens. Store bought bag and a Dirty Bag I looted off a colicoid, I think.

Zun note: There is a chat command to rename items now. I removed the unique power on all bags because of this.

zunath commented 2 years ago

Bug Report Viscara - Mountain Valley Map doesn't appear to work either, in addition to the Wildwoods.

Also now I don't believe any of the previous zones maps have saved in full after using the map item, apart from CZ-220... but not sure if I haven't just done that naturally.

zunath commented 2 years ago

Bug Report Another one I'm not sure if it's a bug or just my build.

Nashtah's don't do any damage on hit to me.

60 - 65 Physical def.

They still afflict me with poison which ticks for acid damage.

Same zone, different lizard. Cairnmogs seem to get stuck in this cycle of pushing the player and not attacking, making them far, far easier to handle. Maybe just a quirk of NWN though?

zunath commented 2 years ago

Bug Report Republic Base door doesn't work and it literally told me to inform an admin lmao :')

zunath commented 2 years ago

Bug Report Sometimes get this bug where my character gets stuck running in place and I can't move, happened once before and I've got it again just now on a newly made character literally standing in the spot I spawned in. Relogging sortof fixes it. First time I had to relog like 3-4 times but it eventually started working again. Maybe just a NWN thing, not sure?

Zun note: Animation related, not something I can fix. Crossing it off but open to someone else taking a stab at fixing it.

zunath commented 2 years ago

Bug Report Another Bounty Guild task reporting error. I had 'Kill 10x Mynocks [Rank 1] {ACCEPTED}' showing in the list... so I click into it to hand it in. Imagine my surprise when I hadn't accepted it yet :')

For what it's worth, the tasks DO WORK, they just seem to be a bit all over the place with regards to displaying Available/Accepted properly haha.

Bug Report Spam sorry, but just as an addition to the previous bug on Bounty Hunter's Guild quests, I've just noticed more than one quest was displaying Accepted before I picked it up, Kath Hound ones for Fur and kills.

These are all quests I've done before, so I feel like the database is remembering I've accepted them once before and is saving the status, now whenever that mission appears in my list again it's still Accepted, but then when I actually accept it, it changes status over to 'Available' again, even tho it's an active mission now.

Hope that makes more sense!

zunath commented 2 years ago

Bug Report I'm not even sure how to report this but Viscara Wildlands have been filled with trees that arent harvestable. I.E., they are the harvestable tree model, but you can't mouseover them, they aren't called tree, cant be targeted with harvester. And there's like, quite a lot of them. Definitely weren't here earlier. Pic related in discord tbh.

image

zunath commented 2 years ago

[Feedback/Suggestion]

The Mandalorians on Viscara seem to drop a set of weapons that are basically tier 1's with an additional +1 damage, which are neat, but by the time you get to them you're already using Tier 2, which kinda makes the weapons only good for picking up to sell/give to lower level players.

Would recommend maybe making them tier 2 +1, or even just basic tier 3's since by the time you reach the mando base you're only a few levels away from T3, makes a nice little reward to hold onto and save you spending credits at the vendor?

Also

[Bug]

The Mandalorian Pistol has 4 Physical Damage, 2 less than the Tier 1 Basic Pistol from the store. All the other weapons I've looted so far have been Tier 1 +1 damage.

zunath commented 2 years ago

swlor-server_1 | [19:55:54 INF] C# Script 'qst_collect_dist' threw an exception. Details: swlor-server_1 | swlor-server_1 | Exception type: System.Collections.Generic.KeyNotFoundException swlor-server_1 | Message : The given key 'mynock_tooth' was not present in the dictionary. swlor-server_1 | Stacktrace: swlor-server_1 | at System.Collections.Generic.Dictionary`2.get_Item(TKey key) swlor-server_1 | at SWLOR.Game.Server.Service.Quest.DisturbItemCollector() in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Service\Quest.cs:line 418 swlor-server_1 | at SWLOR.Game.Server.Core.Internal.RunScripts(String script) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Core\Internal.cs:line 133

zunath commented 2 years ago

Bug Report While changing character outfit I would consistently get the UI crash (using 0.34 or whatever, havent downgraded client) after the 3rd item appearance I would select. This did not seem to have much to do with how much scrolling or moving through the menus I did, as I was applying appearance 250 to every piece, and with my window expanded whenever I clicked from thigh to shin to foot etc, 250 was just in the list to the right side, so it was as easy as simply clicking.

Despite this, it crashed every time after the 3rd item. So after doing my bicep, then forearm, it broke on the hand. Doing the legs I got through thigh, shin, broke on the foot. Found similar with doing the rest, done both shoulderpads then it crashed which I went to fix my chestpiece etc. Seemed quite consistent in that, atleast for appearance menu.

Zun note: Couldn't reproduce this. Maybe it's fixed with the workaround applied to NUI windows? Crossing it off for now until someone else reports it happening again on a new build.

zunath commented 2 years ago

Bug Report When you put stacked ore in a refinery it takes the whole stack and gives you 1 refined metal back.

Bug Report Stacked ore counts as 1 if you hand in the stack for the 4x Raw Veldite quest on CZ-220.

zunath commented 2 years ago

Bug Report Force Push does not give XP. Tested with and without lightsaber XP sharing enabled. It does not give XP when used, or when enemy is killed. Nor does whether or not the enemy resists it change this.

zunath commented 2 years ago

Bug Report Throw Lightsaber Holding W to run forward while using this ability causes the weapon animation to freeze. The end result of this is until you use the ability again your weapon will be floating several meters out from your hand indefinitely. Easily fixed by using the ability again while not holding W (moving is fine, but the forced movement of WASD is not). This bug persists after unequipping/reequipping the weapon.

Bug Report Addendum to the previous Throw LIghtsaber bug: Moving while the lightsaber is returning to you also causes this.

Zun note: I can't do anything about this. It's an issue with the animation. Someone else will need to look at it.

zunath commented 2 years ago

Bug Report The default head for cathar females, once switched off of, cannot be selected again as it doesn't appear in the list. Please add it to the list.

zunath commented 2 years ago

Bug Report Explosives in Darryn Beto's store have the description of medical supplies.

zunath commented 2 years ago

Bug Report Transition from Viscara - Wildlands to Viscara - Wildwoods drops you in the middle of the blue rectangle for the transition, makes it quite easy to misclick and go back. Could be resolved by just dropping the player a little further ahead of it on entry.

Bug Report Transition from the Interior of CZ-220 going into the Spaceport drops you behind the door, which causes you to walk through the transition again unless you click outside of it. Minor annoyance. Could be fixed by spawning the player on the other side of the transition doorway.

Bug Report Transition from Viscara - Wildlands to Viscara - Lake spawns you in the middle of the blue rectangle for the transition, makes walking through again easily done, annoying, etc. Could fix it by moving the player spawn forward infront of the transition.

zunath commented 2 years ago

Bug Report No flour added to the barman on CZ-220.

And the flour that has been added to Chef Master Yu in Veles is just 'Flour' and the recipe calls for 'Viscaran Flour'. Looking at the spreadsheet, there looks to be different flour for each tier.

zunath commented 2 years ago

Bug Report Krystalle's quest is still called Daggers for Krystalle but you get her Spears and Pistols now. Rename maybe?

zunath commented 2 years ago

Bug Report The Veles Colony store does not sell a Spiritmaster Helmet

zunath commented 2 years ago

Bug Report Force Heal has a range of 5 meters. In Live/Depreciated it has a pretty far range. Should probably sit comfortably at 25-30 meters static in my opinion- but subject to testing obviously.

zunath commented 2 years ago

Bug Report Killing the colicoid doesn't count for the quest from halron.

zunath commented 2 years ago

Crash caused - likely during combat with the Fleshleader NPC (using a lightsaber):

Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object. at SWLOR.Game.Server.Service.Ability.IsAbilityToggled(String playerId, AbilityToggleType toggleType) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Service\Ability.cs:line 442 at SWLOR.Game.Server.Native.ResolveAttackRoll.GetStrongStyleAbilityType(CNWSItem weapon, CNWSCreature attacker) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Native\ResolveAttackRoll.cs:line 594 at SWLOR.Game.Server.Native.ResolveAttackRoll.OnResolveAttackRoll(Void thisPtr, Void pTarget) in C:\Projects\SWLOR_NWN\SWLOR.Game.Server\Native\ResolveAttackRoll.cs:line 90

zunath commented 2 years ago

Bug Report If you gain an AP from levelling up while your character sheet is open it'll update to say you have 1 available AP in brackets, but you can't actually spent it, the plusses dont appear. Just need to re-open interface for it to update.

zunath commented 2 years ago

Bug Report Kolto Grenade doesn't give any devices XP. Not sure if intentional?

Would be cool if it gave a little bit per tick when it heals, or maybe award kill XP if someone (user or ally) kills a monster that is in the level range whilst under the effects of the Heal Over Time? Dunno if you could even rig that up.

zunath commented 2 years ago

Bug Report Feedback on Finesse Vibroblades

Finesse Vibros are almost certainly too weak at the moment. CZ220 was OK, relatively low damage but not too bad overall. Skipped wildlands cos chad, went straight to farming Kinrath which are now more scary (nice poison), but doable. Got to level 10. Had my titan gear and knife, still could barely kill outlaws. mfers have stabproof vests, 1 damage all day long and 2 damage crits if you're lucky. Decided to go try my luck in the mountains. Couldn't even do damage to cairnmogs. Nashtahs are also far more deadly now, but I could do very low damage to them but didn't get a chance to test properly cos of the immortal cairnmog on my tail. In a bit of a rut, since I can't really kill anything that'll give me XP, so I decided to go try and level auxiliary skills to get a few more AP. Also couldn't damage the Colicoid which was at level 10 with a titan knife. Managed to do 1 damage with a basic katar instead and no levels. Which leads me to...

Bug Report Feedback on Devices

Devices are cool as heck and with a half decent build they start doing a bit of damage, but I feel like they're just way too difficult to level because of the long cooldowns and the 'XP-leeching' style of level up.

Would it be worth trying to have a server wide discussion on how people feel about that style of levelling? I personally feel that it just leeches from your main weapon XP, throws your armor/weapon levels all out of sync and generally just makes levelling whatever auxiliary skill it is, be it devices or Force powers, really difficult and grindy. In Legacy the 'best way' to level them was almost always to just go back at max level and kill things unarmed while using force powers or whatever which just seems really gimicky and so far Revamps feeling similar, I've got half the devices level of everything else so far.

I think it would be a simple enough change, just make them grant XP on use, or give full kill XP when you use them in a fight?

Zun note: Gave Finesse Vibroblades elemental damage (poison, electric, etc.). No changes to XP gains at the moment - this is all intentional to prevent people from simply using a skill once to gain full XP.

zunath commented 2 years ago

Bug Report Perhaps not a bug, but Saber Strike cancels you out of attacking. This could become frustrating as more attacks per round are gained, as by cancelling the attack sequence you lose all remaining attacks you had that round.

zunath commented 2 years ago

Bug Report No message on log-in when there are credits in the til from selling items (9cr, specifically, from a test transaction of me buying something I placed on market).

zunath commented 2 years ago

Bug Report Not really a bug, bu the Colicoid Experiment is overwhelmed by force powers while largely immune to physical damage. I feel its force defense should be brought up and its physical defence lowered. Also as this is an early game boss, maybe lower its damage a tiny bit and raise its HP. Its XP gain is a little low for a "boss" tier enemy, too. Maybe have small waves of weaker experiments come out before the big boss comes out, encouraging players to group up?

At this point this is less and less a bug report. Just wanted to point out how extreme the difference is in difficulty for one type of character vs another.

Zun note: Lowered VIT score from 16 to 12.

zunath commented 2 years ago

Bug Report After killing the Colicoid Experiment with Force Drain, I discovered it did not count toward quest completion on Halron Linth's final quest.

zunath commented 2 years ago

Bug Report I was just subdued by a Valley Nashtah. Possible bug with having subdual mode on causing enemy NPC's to also subdue you as a result. Will test further.

Bug Report After being subdued by an NPC, there doesn't seem to be an expiration on how long you remain subdued.

Bug Report After logging out and back in to fix bug with being permanently subdued by an NPC, I was able to respawn. On respawning, my HUD was gone and my character was invisible to me, requiring me to relog. Unclear if this is only due to the strangeness associated with being subdued by an NPC or if it happens in all subdual instances. Potentially very serious, especially when it comes to DM events where it may be needed for NPC's to subdue players.

Bug Report Every time after transitioning now after having been subdued by an NPC my character is invisible and cannot be moved. Submitting screenshots in #server-revamp.

Zun note: Subdual mode should have never worked against NPCs - only players. This has been fixed. Additionally, SetCurrentHitPoints was used to revive the player which shouldn't be used. It likely caused all these other issues.

zunath commented 2 years ago

Bug Report My Delta Great Sword has a bag on the handle.

zunath commented 2 years ago

Bug Report Players using custom portraits see an empty image on the character sheet. We should default to the unknown human if this happens.

Zun note: There's no way for us to know if the client has the portrait installed. For this reason, no action was taken to address this. Players can change their portrait if they no longer have the file.

zunath commented 2 years ago

Bug Report Vipers on Mon Cala are doing /a lot/ of Acid damage on hit.

129 Phys Def 78 Force Def

Bug Report Amphi-Hydrus' on Mon Cala do /a lot/ of electrical damage on hit.

129 Phys Def 78 Force Def

zunath commented 2 years ago

Bug Report Workshop on Mon Cala still has all the legacy workbenches, seems to have working Fabrication, Engineering and Cookpot but no Smithing table.

zunath commented 2 years ago

Bug Report Reminder to adjust the Racial stat modifier for the new system. AGI?

Bug Report Human racials have negative and minus when they're ment to be the base line for all races. Thus not having any extra or negative stats.

zunath commented 2 years ago

Bug Report Stats on the Poacher weapons that drop in the Eco Terrorist Hideout on Mon Cala all seem to have wrong damage stats. They're just really low, possibly from some older build? All tier 2, but stats comparable to tier 1 for the most part.

Unsure about the armour, its forcie stuff and I dont really have a comparison. Worth looking maybe. Also T2.

zunath commented 2 years ago

Bug Report The Entrance to Dac City doesn't work.

zunath commented 2 years ago

Bug Report General Vendor Onmofo Noll on Mon Cala doesn't appear to have the T3 Light Ring, Forza Ring. Has the others.

zunath commented 2 years ago

Bug Report Possible Bug / Feedback

First fight with a Qion Slug felt really good after finishing Mon Cala and kinda dominating there for a few levels at the end. Not too hard, not too easy either. They do decent damage, but it's a bit weird. They were hitting me for around 20 damage with their hits, but then I'd take 1 damage and 1 damage seperately, all physical. Seems like they might be supposed to have elemental damage of some sort that isn't applied? Overall don't feel too badly balanced though.

Bug Report Additional to the last report. Just realised that the slugs apply a damage over time effect, which has a bleed icon, but it just does regular physical damage and doesn't make the player bleed physically like other effects.

Bug Report Feedback - Hutlar

Had a few fights with the Byssk and Tigers now, they seem really well balanced. Tigers do decent damage, got a decent evasion for my stats right now, die fairly quickly though so not too much of a handful.

Byssk on the other hand are worthy adversaries. Not overpowered like the funny 100 damage vipers, but their high APR is really nasty and they can overwhelm you fast, had to manage my stuns and healing to stay alive, close fights.

Stats - Might - 22 Percep - 20 Vit - 21 Wil - 10 Agi - 12 Soc - 10 Attack - 88 Accuracy - 89 Evasion - 76 Phys def - 157 Force def - 100

zunath commented 2 years ago

Bug Report 'Enter the Ruin' doorway on Hutlar - Cloning Test Site doesn't work, or if it requires a key it doesn't say so, just does nothing. Or if it's not hooked up, my bad!

Zun note: Area needs to be expanded. It's only one zone and there's not enough content for it. Disabled the transport object for now.