search

zurb / foundation-apps

The first front-end framework created for developing fully responsive web apps.
http://foundation.zurb.com/apps
MIT License
1.58k stars 216 forks source link

Menu list-items: flex alignment is declared as both "center" and "stretch" #783

Open HoldenCreative opened 8 years ago

HoldenCreative commented 8 years ago

Wonderful framework! ~ thanks.

Please see line 41 and 47 of: https://github.com/zurb/foundation-apps/blob/master/scss/components/_menu-bar.scss

The align-items value for a menu list-item is declared twice (in conflict).

// Menu item
  > li {
    // This flex setting makes each item an equal width
    flex: 1 0 0;
    align-items: center;

    // The list item itself is also a flex container, to center links in case they have different height
    display: flex;
    align-items: stretch;