zwave-js / node-zwave-js

Z-Wave driver written entirely in JavaScript/TypeScript
https://zwave-js.github.io/node-zwave-js/
MIT License
755 stars 613 forks source link

Double tap not supported on Honeywell/Jasco 39348 switches #5209

Closed manonstreet closed 1 year ago

manonstreet commented 2 years ago

Is your problem within Home Assistant (Core or Z-Wave JS Integration)?

NO, my problem is NOT within Home Assistant or the ZWave JS integration

Is your problem within Z-Wave JS UI (formerly ZwaveJS2MQTT)?

NO, my problem is NOT within Z-Wave JS UI

Checklist

Describe the bug

What causes the bug? Missing configuration values in the Honey/Jasco 39348 config file

"treatBasicSetAsEvent": true needs to be added to the compat section of the device config file

What do you observe? Double taps are not available for this device, but are for similar jasco/ge switches

What did you expect to happen? An event to be fired upon double tap

Steps to reproduce the behavior:

  1. Double tap a 39348 light switch on or off
  2. Click examine the logs
  3. Notice that double taps send property currentValue updates as opposed to property event

Device information

Manufacturer: Honeywell/Jasco Model name: 39348 Node ID in your network: 29, 32, and 51

How are you using node-zwave-js?

Which branches or versions?

version: node-zwave-js branch: 10.3 zwave-js-ui branch: 8.4.1

Did you change anything?

no

If yes, what did you change?

No response

Did this work before?

Yes (please describe)

If yes, where did it work?

It worked with openzwave before switching to this package.

Attach Driver Logfile

Not applicable. Empty log supplied.

N/A
AlCalzone commented 1 year ago

@zwave-js-bot add compat flag to 0x0039:0x4952:0x3036

        "treatBasicSetAsEvent": true
zwave-js-bot commented 1 year ago

🔨 I created a PR at #5543 - check it out!