zwave-js / zwave-js-ui

Full featured Z-Wave Control Panel UI and MQTT gateway. Built using Nodejs, and Vue/Vuetify
https://zwave-js.github.io/zwave-js-ui
MIT License
984 stars 201 forks source link

[HASS] Show warning when renaming device to name containing 'æ', 'ø' or 'å' #1364

Open AlfHou opened 3 years ago

AlfHou commented 3 years ago

Is your feature request related to a problem? Please describe. When ZwaveJS2MQTT publishes a disovery topic for home assistant that contains any of the Norwegian/Scandinavian characters Æ, Ø or Å, home assistant fails to discover the device. I've created a issue for it in the home assistant repo here

Describe the solution you'd like It would be nice if ZJ2M showed a warning, or refused to update the name of a device if it contained any of the above characters (and possible others). Something like the error at the bottom of this page.

Describe alternatives you've considered Either a warning should show, or it should refuse to change the name.

Additional context Something like this is what I had in mind:

image

I might be able to implement this myself if you think this is a good idea. I just have to finish all my exams first 😛

robertsLando commented 3 years ago

@AlfHou I had users asking me to add some more allowed chars like Norwegian/Scandinavian ones, I think this should be handled by the user, those chars are allowed on MQTT side. BTW If you would like to implement this I will check it

AlfHou commented 3 years ago

Perfect! I'll take a look at adding some sort of warning if home-assistant discovery is turned on then.

ghost commented 3 years ago

Is used about four hours on this issue before i noticed that it was only devices that contained 'æøå', was not discovered by hass. So a simple warning that hass is not able to discover it would be nice.

robertsLando commented 3 years ago

@slippern Are you using z2m with mqtt discovery or zwavejs integration?

ghost commented 3 years ago

@slippern Are you using z2m with mqtt discovery or zwavejs integration?

Im using z2m with mqtt discovery.