search

zwave-js / zwave-js-ui

Full featured Z-Wave Control Panel UI and MQTT gateway. Built using Nodejs, and Vue/Vuetify
https://zwave-js.github.io/zwave-js-ui
MIT License
984 stars 201 forks source link

Add "latest" tag to last release for ghcr.io support #4002

Closed prilly-dev closed 1 week ago

prilly-dev commented 1 week ago

Is your feature request related to a problem? Please describe. When using ghcr.io instead of docker hub for puling release images the correct tags needs to be applied to the releases, currently only version number is added as a tag.

Describe the solution you'd like Please add the tag latest to the last release (see how HA did solve this with actions)

Describe alternatives you've considered using docker hub

Additional context Its nice to be able to pull the image directly from ghcr instead of docker hub, removes the problem if publish fails, removes overhead and so on. but it requires similar tag routine as docker hub to be able to use latest (pull from ghcr with version number tag works fine, but will not increment the same way as latest

kpine commented 1 week ago

What's missing? https://github.com/zwave-js/zwave-js-ui/pkgs/container/zwave-js-ui/304613354?tag=latest

image

https://github.com/zwave-js/zwave-js-ui/pkgs/container/zwave-js-ui

prilly-dev commented 1 week ago

Thank you, i noticed it worked like intended 👍

docker hub uses: zwavejs/zwave-js-ui:latest ghcr: ghcr.io/zwave-js/zwave-js-ui:latest

didnt notice the "-"