zydezu / ModernX

My fork of modernX (a replacement for MPV that retains the functionality of the default OSC), adding additional features - see builds at: https://github.com/zydezu/mpvconfig
131 stars 5 forks source link

Cannot set 'showwindowtitle' and 'titleBarStrip' to false in script-opts/modernx.conf #26

Closed emk2203 closed 5 months ago

emk2203 commented 5 months ago

When I try to set showwindowtitle and titleBarStrip to 'false' in script-opts/modernx.conf, I get the following errors:

   modernx: Error: Can't convert 'false' to boolean!
   modernx: script-opts/modernx.conf:6 error converting value 'false' for key 'showwindowtitle'
   modernx: Error: Can't convert 'false' to boolean!
   modernx: script-opts/modernx.conf:7 error converting value 'false' for key 'titleBarStrip'

Any way to fix this? The window title is a bit annoying in fullscreen mode.

This is how the modernx.conf file looks:

scalefullscreen=2.0
scaleforcedwindow=1.5
hidetimeout=3500
fadeduration=300
minmousemove=2
showwindowtitle=false
titleBarStrip=false
titlefontsize=36
OSCfadealpha=300
timefontsize=24

As a workaround, I have changed the values in scripts/modernx.lua.

zydezu commented 5 months ago

In a conf file, 'false' should be 'no' and 'true' should be 'yes'