zzzprojects / EntityFramework-Effort

Entity Framework Effort is a powerful tool that enables a convenient way to create automated tests for Entity Framework based applications.
https://entityframework-effort.net/
MIT License
431 stars 99 forks source link

IDataLoader usage documentation is misleading and behavior is weird. #135

Open jons-aura opened 6 years ago

jons-aura commented 6 years ago

The documentation for the DbConnectionFactory CreateTransient overload that takes an IDataLoader says

If the database is accessed the first time, then its state will be initialized by the provided object.

The problem is that what it actually does is get and store the Type object and the value of the Argument parameter which although there is a documentation note that

Gets or sets the argument that describes the complete state of the data loader.

this is not at all clear from the CreateTransient usage documentation

https://github.com/zzzprojects/EntityFramework-Effort/blob/1b772b2dca1249132dfb874e77afdc73a0c8e80f/Main/Source/Effort.Shared/DbConnectionFactory.cs#L160

JonathanMagnan commented 5 years ago

Thank you for reporting @jons-aura ,

We will look at it.

Best Regards,

Jonathan


Performance Libraries context.BulkInsert(list, options => options.BatchSize = 1000); Entity Framework ExtensionsEntity Framework ClassicBulk OperationsDapper PlusLinqToSql Plus

Runtime Evaluation Eval.Execute("x + y", new {x = 1, y = 2}); // return 3 C# Eval FunctionSQL Eval Function