search

0-duke / wdpassport-utils

WD Passport Ultra Linux Utilities
GNU General Public License v2.0
228 stars 84 forks source link

Support latest WD drive, updates #11

Closed JoshData closed 4 years ago

JoshData commented 5 years ago

Hey @0-duke. Thanks for your work to create this utility. I bought a new WD drive yesterday and was grateful that a tool existed to unlock the drive from Linux.

I had to make some modifications, though --- the drive reported it was using a new cipher (0x31) for which there was no known key length. But, luckily, the drive reports the key length for the active cipher, so I was able to use the information from the drive to get it to work. While I was there, I made a little afternoon project out of updating the code, replacing subprocess (which is prone to security vulnerabilities) with calls to pyudev, and some other things I think are improvements. In this PR, I'm also slurping in a few commits from @crypto-universe who made some changes to port the code (and the py_sg library!) to Python 3.

Are you still interested in maintaining this project? If so, I'd love to get these changes merged so I'm not maintaining a fork. If not, let me know --- I totally understand what it's like to have folks showing up out of the blue in repositories that you've moved on from long ago.

tvladyslav commented 5 years ago

@JoshData, I'm glad that you found my commits useful. Just keep in mind, that those changes fixes decryption only. My WD contains useful data and I can't test secure erase feature and some other functions.

JoshData commented 5 years ago

@crypto-universe I tested everything on a new drive. :) All of the functionality seemed to be working.

scr4bble commented 4 years ago

Hi guys, @0-duke please find few minutes to answer to these messages. Thanks a lot for your work - it would be great if this project has a maintainer. I was also really glad it exists and I can use the encryption on my external HDD on linux.

@JoshData, @crypto-universe thanks a lot for the contributions. I just found out that new fedora is dropping support for python2 so it is most appreciated you have made the adjustments.

0-duke commented 4 years ago

Hi @JoshData, @crypto-universe, first of all I want to apologize for not contributing to the project for several years and leave it stalled for a while. I just merge your pull requests and I wanted to thank you very much for the amazing work done. Your code is definitely a big improvement over the original code and I should have merged it way sooner. Thanks a lot again and keep up the good work.

JoshData commented 4 years ago

Excellent!

tvladyslav commented 4 years ago

@scr4bble , @0-duke my pleasure. I use Fedora, so there was a motivation for migration between Pythons.