0-yibai / pe

0 stars 0 forks source link

Unable to add two buyers with the same name but different phone number and different email #2

Open 0-yibai opened 2 months ago

0-yibai commented 2 months ago

In reality, two buyers may have the same name (and I think this is not very rare) but different phone numbers and different emails. However, this is not allowed in this app.

Screenshot 2024-04-19 at 16.20.19.png

Steps to produce: Run the following two commands in sequence. addBuyer n/James p/98765432 e/james@gmail.com budget/20000 type/Hdb addBuyer n/James p/12341234 e/iamanotherjames@gmail.com budget/20000 type/Hdb

nus-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add person of same name, although number and email is different

I am unable to add person of same name. 2 people can have the same name, with different phone number and email.

Screenshot 2024-04-19 at 4.18.46 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#2488] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We have already addressed this issue in our planned enhancement. Refer to the attachment below. image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Since this is specified as a planned enhancement in DG, I think it is better if you mark it as 'not in scope' instead of 'rejected'.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** As described in the original issue, in reality, two buyers may have the same name (and I think this is not very rare) but different phone numbers and different emails. Hence it is quite likely to cause some inconvenience for users.